.NET: ci: update Microsoft.CodeAnalysis.NetAnalyzers and Microsoft.VisualStudio.Threading.Analyzers versions - #8166
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Two CPM-disabled sample projects retain explicit references to both outdated analyzer versions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates repository-wide .NET analyzer versions to reduce false positives.
Changes:
- Updates .NET analyzers to
10.0.400. - Updates threading analyzers to
18.7.23.
File summaries
| File | Description |
|---|---|
dotnet/Directory.Packages.props |
Updates centrally managed analyzer versions. |
Review details
Suppressed comments (1)
dotnet/Directory.Packages.props:168
- This central bump does not reach the two CPM-disabled sample projects:
AgentWithRAG_Step05_Neo4jGraphRAG.csproj:34andAgentWithMemory_Step06_MemoryUsingAgentMemory.csproj:60remove this inherited reference and still re-add version17.14.15. They will continue using the analyzer version called out as outdated, so their explicit pins should also be updated to18.7.23.
<PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="18.7.23" />
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): 37fc801b2231
Model: gpt-5.6-sol-fast
Overview
The PR updates two centrally managed, build-time-only analyzer packages while retaining private-assets isolation and existing analyzer enforcement in CI. Central package management and full-solution warning-as-error builds constrain compatibility risk, and the change introduces no runtime, public API, persistence, or security surface. No Critical, High, or Medium defect was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall line coverage in commit 82a23ba in the Show a line coverage summary of the most covered files.
Updated |
…udio.Threading.Analyzers versions Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
6c3244b to
82a23ba
Compare
Updates Threading and Net Analazers because we're on outdated versions that cause a lot of false positives